Remove flaky error log checking from parachain extrinsic test #10710
+0
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Dec 23, 2025
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
I know that I said this, but maybe we should actually remove the entire test? Spawning an entire network to just test that we can finalize a transaction is ultra wasteful. We have already other tests sending transactions, if not we could also just move the sending of a tx there and wait for it to be finalized.
Author
|
Yes you are right, this flow is covered in the runtime_upgrade.rs |
Contributor
|
+1 to remove since this is already cover. @skunert if you are agree we can just remove this one. |
Contributor
|
Review required! Latest push from author must always be reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the entire error detection for loop. The test now focuses only on checking that the parachain extrinsic gets finalized, without the flaky error log checking.
closes #10704