Skip to content

Remove flaky error log checking from parachain extrinsic test #10710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mchristou wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove flaky error log checking from parachain extrinsic test #10710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9efd47
Remove flaky error log checking from parachain extrinsic test
mchristou Dec 23, 2025
868d275
Remove parachain_extrinsic_get_finalized since the flow covered in ot…
mchristou Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions cumulus/zombienet/zombienet-sdk/tests/zombie_ci/parachain_extrinsic_get_finalized.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
// SPDX-License-Identifier: Apache-2.0

use anyhow::anyhow;
use tokio::time::Duration;

use crate::utils::{initialize_network, BEST_BLOCK_METRIC};
use cumulus_zombienet_sdk_helpers::submit_extrinsic_and_wait_for_finalization_success_with_timeout;
use zombienet_orchestrator::network::node::{LogLineCount, LogLineCountOptions};
use zombienet_sdk::{
subxt::{self, dynamic::Value, OnlineClient, PolkadotConfig},
subxt_signer::sr25519::dev,
Expand Down Expand Up @@ -48,61 +46,6 @@ async fn parachain_extrinsic_gets_finalized() -> Result<(), anyhow::Error> {
.is_ok());
}

for node in [alice, bob, charlie] {
log::info!("Ensuring {} does not report any error", node.name());

let result = node
.wait_log_line_count_with_timeout(
".*kernel security feature.*not available.*error.",
false,
// Do not wait for more logs. The lines we are looking for appear at the node
// startup, which we must have clearly reached if we are here.
LogLineCountOptions::new(|n| n == 0, Duration::from_secs(0), false),
)
.await?;

// If above line appeared then increase expected error count
let mut error_cnt_expected = if result.success() { 0 } else { 1 };

let result = node
.wait_log_line_count_with_timeout(
r"error=Pool\(InvalidTransaction\(InvalidTransaction::MandatoryValidation\)\)",
false,
LogLineCountOptions::new(move |n| n > 0, Duration::from_secs(2), true),
)
.await?;

// We want to search for lines containing 'error' but we need to ignore below line (which
// occasionally appears):
// error=Pool(InvalidTransaction(InvalidTransaction::MandatoryValidation))
// In a perfect world, we could use a regex with look-around, e.g.
// (?!.*error=Pool(InvalidTransaction(InvalidTransaction::MandatoryValidation))).*error.*
// but unfortunately, `regex` crate used by zombienet-sdk does not support look-arounds.
//
// Therefore, we will do as follows:
// - First, search for lines containing:
// error=Pool(InvalidTransaction(InvalidTransaction::MandatoryValidation))
// - Add the number of such occurrences to the expected number of 'error' lines
// - Then, search for lines containing: error
if let LogLineCount::TargetReached(cnt) = result {
error_cnt_expected += cnt;
}

let result = node
.wait_log_line_count_with_timeout(
"error",
false,
// Do not wait here, we already waited in previous step
LogLineCountOptions::new(
move |n| n == error_cnt_expected,
Duration::from_secs(0),
false,
),
)
.await?;
assert!(result.success(), "node {} reported error: {:?}", node.name(), result);
}

log::info!("Ensuring parachain extrinsic gets finalized");
let call = subxt::dynamic::tx("System", "remark", vec![Value::from_bytes("xxx".as_bytes())]);
let charlie_client: OnlineClient<PolkadotConfig> = charlie.wait_client().await?;
Expand Down
Loading