Skip to content

refactor: move source code to src directory #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 7, 2025

What's New?

  • moves source code from custom/lib/ to src/ to conform with modern php lib practices
  • moves tests out of source directory and into a root tests/ directory

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the PSG-5686-change-dir-structure branch from a3dbc72 to c23b809 Compare January 7, 2025 22:19
@ctran88 ctran88 marked this pull request as ready for review January 7, 2025 22:20
@ctran88 ctran88 requested a review from a team January 7, 2025 22:21
@ctran88 ctran88 force-pushed the PSG-5559-use-enums branch from a5a5897 to cd78ec1 Compare January 8, 2025 22:19
@ctran88 ctran88 force-pushed the PSG-5686-change-dir-structure branch from c23b809 to 5afa6ce Compare January 9, 2025 01:07
Copy link
Contributor

@vanessa-passage vanessa-passage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Curious if nesting this under /custom was creating problems or was this just to streamline the file structure?

Base automatically changed from PSG-5559-use-enums to main January 10, 2025 19:06
@ctran88
Copy link
Contributor Author

ctran88 commented Jan 10, 2025

Code changes look good.

Curious if nesting this under /custom was creating problems or was this just to streamline the file structure?

it was just to streamline it based on looking around at various php libs

@ctran88 ctran88 force-pushed the PSG-5686-change-dir-structure branch from 5afa6ce to e54af75 Compare January 10, 2025 19:09
@ctran88 ctran88 merged commit cd32d82 into main Jan 10, 2025
4 checks passed
@ctran88 ctran88 deleted the PSG-5686-change-dir-structure branch January 10, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants