Fix for iOS crash when calling hide() after the indicator has already… #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want |
|
Why does this PR affect 1721 files? I would also like this issue resolved but this PR seems broken to me |
Author
|
My original pull request was never merged, and I forgot it was still open. I then also removed the entire demo directory because it contained paths that were too long for Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… been hidden
By nilling out the
progressIndicatorinstance variable in the hide method, multiple calls tohide()after a progress indicator has already hidden will prevent this plugin from crashing on iOS.