Skip to content

Commit

Permalink
PSQLADM-511: proxysql-admin syncusers hangs at 1000 DB user or above
Browse files Browse the repository at this point in the history
https://perconadev.atlassian.net/browse/PSQLADM-511

Follow-up fix:
Passwords having single quote (') characters were not processed
properly due to the missing of escaping.
  • Loading branch information
venkatesh-prasad-v committed Apr 17, 2024
1 parent 4521189 commit f0e8ffb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions proxysql-admin-common
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,11 @@ function syncusers() {

username=${user}
password="${mysql_users_full_hash[${username}]}"

# Since we're using single quotes within the SQL statement, only need
# to escape the single quotes for SQL
password=${password//\'/\'\'}

debug "$LINENO" "Processing MySQL user: '${username}'"

# Check if the user exists in ProxySQL
Expand Down

0 comments on commit f0e8ffb

Please sign in to comment.