Sort availability zones for db cluster #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harjain99
changed the title
harjain99
reviewed
Sep 25, 2024
| @@ -182,7 +183,9 @@ public List<String> getAvailabilityZones() { | |||
| } | |||
|
|
|||
| public void setAvailabilityZones(List<String> availabilityZones) { | |||
| this.availabilityZones = availabilityZones; | |||
| List<String> modifiableList = new ArrayList<>(availabilityZones); // creates a new modifiable list | |||
There was a problem hiding this comment.
We probably shouldn't blindly create a new list every time.
We should handle the conversion in the copyFrom.
@Override
public void copyFrom(DBCluster cluster) {
setAvailabilityZones(new ArrayList<>(cluster.availabilityZones()));
harjain99
reviewed
Sep 25, 2024
| @@ -182,7 +183,9 @@ public List<String> getAvailabilityZones() { | |||
| } | |||
|
|
|||
| public void setAvailabilityZones(List<String> availabilityZones) { | |||
| this.availabilityZones = availabilityZones; | |||
| List<String> modifiableList = new ArrayList<>(availabilityZones); // creates a new modifiable list | |||
| Collections.sort(modifiableList); | |||
There was a problem hiding this comment.
The sort should take place on the getter instead.
|
Updated |
harjain99
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #669
Description
This pull request addresses the need to maintain a consistently sorted order of 'availability zones' in our code.
Changes
The setter method now takes the input list of availability zones, creates a new modifiable list from it, sorts this list, and assigns it back to the availabilityZones field.