Skip to content

Sort availability zones for db cluster #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Sort availability zones for db cluster #662

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac07f06
Sort the list of availability zones
Russsnizza Sep 18, 2024
6ffd6c1
Import Collections
Russsnizza Sep 18, 2024
9d7db0f
Sort availability zones in setter method
Russsnizza Sep 19, 2024
a231214
Add an empty line
Russsnizza Sep 19, 2024
981af9d
Sort availability zones in getter and handle the conversion in the co…
Russsnizza Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/gyro/aws/rds/DbClusterResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;
import java.util.Collections;

import com.psddev.dari.util.ObjectUtils;
import gyro.aws.Copyable;
Expand Down Expand Up @@ -182,7 +183,9 @@ public List<String> getAvailabilityZones() {
}

public void setAvailabilityZones(List<String> availabilityZones) {
this.availabilityZones = availabilityZones;
List<String> modifiableList = new ArrayList<>(availabilityZones); // creates a new modifiable list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't blindly create a new list every time.
We should handle the conversion in the copyFrom.

    @Override
    public void copyFrom(DBCluster cluster) {
        setAvailabilityZones(new ArrayList<>(cluster.availabilityZones()));

Collections.sort(modifiableList);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort should take place on the getter instead.

this.availabilityZones = modifiableList;
}

/**
Expand Down
Loading