Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TeleopSubcomponent to re-tare and change F/T threshold #140

Merged
merged 3 commits into from
May 13, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented May 13, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

This PR, which builds upon ada_feeding#183, extends the TeleopSubcomponent as follows:

  1. On mount and when the refresh button is clicked, has the teleop button re-tare the F/T sensor.
  2. From the InfoModal, gives users the option to increase the F/T threshold (to 75N) and restore it (back to 1N).

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Pull ada_feeding#183, re-build and source the workspace.
  • Launch the system in real: python3 src/ada_feeding/start.py
  • Load the teleop component, verify the F/T sensor re-tares and the correct controller is loaded:
    • InfoModal
    • Settings > Above Plate
  • Click refresh, verify the same as above.
    • InfoModal
    • Settings > Above Plate
  • In the InfoModal, increase the force threshold. Verify it actually increases.
  • Unmount the teleop component. Verify the force threshold decreases. When you remount it, verify that the button that shows is to "increase" it, not "restore" it to the default.
  • Increase it, then click the decrease button, verify it actually decreases.
  • Increase it, then swap teleop modes. Verify it decreases.
  • Teleop the robot to experience a force, verify that pressing the refresh button allows you to move out of it briefly step-by-step.
  • Teleop the robot to experience a force, verify that increasing the force threshold lets you move out of it all-at-onces.

Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati changed the title Amaln/teleop ft sensor Allow TeleopSubcomponent to re-tare and change F/T threshold May 13, 2024
@amalnanavati amalnanavati merged commit 2dc2dfe into main May 13, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/teleop_ft_sensor branch May 13, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant