Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prevent RobotMotion modal from starting in pause when customizing #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amalnanavati
Copy link
Contributor

Describe this pull request. Link to relevant GitHub issues, if any.

There is an ongoing issue where, when customizing a robot arm configuration, sometimes the RobotMotion modal will start out paused. This PR is an attempt to fix that.

Explain how this pull request was tested, including but not limited to the below checkmarks.

The main challenge is that this issue is hard to recreate. I have had greatest success re-creating it when accessing the web interface from my iPhone, and some success recreating it when accessing the web interface (running on the real robot) from the Arc browser on my laptop. I haven't been able to re-create it when running the robot code on my Ubuntu VM.

  • Recreate the issue: Find a configuration where the issue can be recreated with high probability, document that here.
  • Verify the fix: Pull this branch and run the code, verify the fix works.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant