Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Acquisition Report #145

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Sep 1, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

This PR allows a successful acquisition report even when the user clicks "Skip Acquisition" if acquisition failed (i.e., it failed after acquiring the food). The PR also makes "Skip Acquisition" go directly to the staging configuration.

Note: ada_feeding#197 should be merged before this!

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Launch the code in real.
  • Acquire food, simulate a failure.
  • Verify that Skip Acquisition sends a successful acquisition report.
  • Acquire food, let it complete.
  • Verify that "Move To Mouth" sends a successful acquisition report.
  • Acquire food, let it complete.
  • Verify that "Re-acquire Bite" sends a failed acquisition report.
  • Go to staging, then cancel and go back to resting.
  • Click (one-at-a-time) "Move To Mouth" and "Re-acquire Food," verify that neither sends an acquisition report.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 133ae56 into main Sep 1, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/acquisition_improvements branch September 1, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant