Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option to show Video Feed in Teleop Modal #148

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

amalnanavati
Copy link
Contributor

Describe this pull request. Link to relevant GitHub issues, if any.

This PR, Motivated by the 2024 deployment, creates the option to show the video feed in the Teleop modal. In practice, this works fine when the user is accessing the modal on their computer, but not great on a screen as smart as the smartphone. Thus, by default, we disable this.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Run it, open the teleop modal, verify the video stream doesn't show.
  • Change showVideoFeedDuringTeleop's default value to true, run it, verify it does show.

Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 89dc286 into main Oct 21, 2024
4 checks passed
@amalnanavati amalnanavati deleted the studies/2024_deployment branch October 21, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant