Open
Conversation
Contributor
Author
|
Note: For crediting the icon creators, I have them somewhere else. I am not sure where I should add that in the codebase. Please let me know and I can add that as well! |
Contributor
|
Credit to icon designers should go in https://github.com/personalrobotics/feeding_web_interface/blob/main/feedingwebapp/Acknowledgements.md Often times, the website where you got the icons (e.g., The Noun Project) will have specific guidelines on how to attribute the creators. Follow those guidelines when wording the Acknowledgement statement(s). Make sure the icons are open-source (commonly denoted by having a Creative Commons license) |
Contributor
Author
|
@amalnanavati Thanks for the feedback! I have added the acknowledgments as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this pull request. Link to relevant GitHub issues, if any.
This pull request updates some of the emojis on the web interface. This is linked to Issue number #25. This is to have icons consistent across all devices.
Explain how this pull request was tested, including but not limited to the below checkmarks.
This pull request was tested by running and ensuring the functionality stayed consistent overall.
Before creating a pull request
npm run formatpython3 -m black .in the top-level of this repositoryBefore merging a pull request
Squash and Merge)