-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry button for error page #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. Thank you for addressing this promptly!
I have a few in-line requests for changes, but once those are addressed this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See requested changes. I did test it on my phone with the real robot and it works well.
Describe this pull request. Link to relevant GitHub issues, if any.
This PR includes issue #84 deliverables as detailed in the following:
Added a retry boolean variable in the
RobotMotion.jsx
file. This retry boolean istrue
only when “Robot has encountered an error” text appears. When retry boolean istrue
a Retry button appears in the error page. I placed this button in the latter 50% of the page's viewbox and made it vertically and horizontally centered in that part. I used yellow for this button’s color as this is meant for an unintended / erroneous situation. When this button is clicked, the current robot motion starts again from planning, just like what the footer's resume button does when the robot is paused.UPDATES:
retry
in the function definitionExplain how this pull request was tested, including but not limited to the below checkmarks.
This feature was tested in Ubuntu VM 22.04 chromium and firefox browser in landscape and portrait modes of smartphone, tablet, desktop monitor, and laptop. The retry button appeared as expected and re-started the current action when the retry button is clicked.
Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)