Add priority parameter to attach method in ManagerInterface

[tashik]

Hello!

• Type: code quality
• Link to issue: Code quality issue in Phalcon\Events\ManagerInterface.zep #16817

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:

This pull request fixes #16817

My mini-fix will allow to generate correct ide-stubs. Please, update ide-stubs accordingly if possible.

Thanks,
Natalya

[niden]

@tashik Thank you for this.

Could you please create an issue first, then link it with this PR?
Also, we do not accept PRs towards the master branch so you need to rebase that to point to the v5.0.x

Thanks!

[niden]

@tashik Thank you for this.

Could you please create an issue first, then link it with this PR? Also, we do not accept PRs towards the master branch so you need to rebase that to point to the v5.0.x

Thanks!

Also you might want to use the constant defined in the Manager (DEFAULT_PRIORITY). Move it to the Interface and use it from there

[tashik]

@niden, I have fixed my pull request, created an issue #16817 and connected the PR and the issue. I have rebased my branch to 5.0.x, but there are two commits there which are not mine.

[niden]

@niden, I have fixed my pull request, created an issue #16817 and connected the PR and the issue. I have rebased my branch to 5.0.x, but there are two commits there which are not mine.

Thanks for that. Don't worry about the other commits, they probably came from your rebase.

One last thing if you can. For Zephir we do not have public const it is just const. The code does not compile with the public in there. (see CI run). If you can remove that, we can get the suite to run and then merge it if all is OK.

[tashik]

@niden I have removed constant visibility, sorry for that, I am not familiar with Zephir.

[niden]

Thank you @tashik