Skip to content

Add priority parameter to attach method in ManagerInterface #16816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2025
Merged

Add priority parameter to attach method in ManagerInterface #16816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bf6229
Suppressed Code Sniffer rule for missing namespace.
SidRoberts Sep 27, 2025
991bd4e
Added explicit visibility to constants.
SidRoberts Sep 27, 2025
be81eee
Add priority parameter to attach method in ManagerInterface
tashik Nov 8, 2025
a5004a7
fix on review comment: move constant DEFAULT_PRIORITY to the interface
tashik Nov 9, 2025
a4adcdc
removed constant visibility
tashik Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions phalcon/Events/Manager.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ use SplPriorityQueue;
*/
class Manager implements ManagerInterface
{
const DEFAULT_PRIORITY = 100;

/**
* @var bool
*/
Expand Down
3 changes: 2 additions & 1 deletion phalcon/Events/ManagerInterface.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ namespace Phalcon\Events;
*/
interface ManagerInterface
{
const DEFAULT_PRIORITY = 100;
/**
* Attach a listener to the events manager
*
* @param object|callable handler
*/
public function attach(string! eventType, handler) -> void;
public function attach(string! eventType, handler, int! priority = self::DEFAULT_PRIORITY) -> void;

/**
* Detach the listener from the events manager
Expand Down
9 changes: 3 additions & 6 deletions tests/integration/Mvc/Dispatcher/Helper/DispatcherTestDefaultNoNamespaceController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
<?php
<?php // phpcs:disable PSR1.Classes.ClassDeclaration.MissingNamespace

// @codingStandardsIgnoreStart
use Phalcon\Mvc\Controller;

// @codingStandardsIgnoreSEnd

/**
* \DispatcherTestDefaultNoNamespaceController
* Dispatcher Controller for testing different dispatch scenarios
Expand All @@ -23,8 +20,8 @@
*/
class DispatcherTestDefaultNoNamespaceController extends Controller
{
const RETURN_VALUE_STRING = 'string';
const RETURN_VALUE_INT = 5;
public const RETURN_VALUE_STRING = 'string';
public const RETURN_VALUE_INT = 5;

public function beforeExecuteRoute()
{
Expand Down
Loading