Skip to content

#121 Replace Transcript show: with log: #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#121 Replace Transcript show: with log: #151

wants to merge 1 commit into from

Conversation

JoachimTuchel
Copy link

Fix for #121

gcotelli
gcotelli requested changes Jan 20, 2024
View reviewed changes
src/Glorp/DatabaseAccessor.class.st
anArray do: [ :each |
self dropSequence: each ifAbsent: [ :ex |
Transcript show: (ex messageText ifNil: [ ex printString ]).
self log: ('Drop Sequences failed for <1> with: <2>' expandMacrosWith: each name with: (ex messageText ifNil: [ ex printString ])).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing something in the interpolation code. <1> must be <1s> and <2> must be <2s>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcotelli gcotelli gcotelli requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoachimTuchel @gcotelli