Skip to content

#121 Replace Transcript show: with log: #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoachimTuchel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#121 Replace Transcript show: with log: #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Glorp/DatabaseAccessor.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,10 @@ DatabaseAccessor >> dropSequence: aDatabaseSequence ifAbsent: aBlock [
{ #category : #executing }
DatabaseAccessor >> dropSequences: anArray [


anArray do: [ :each |
self dropSequence: each ifAbsent: [ :ex |
Transcript show: (ex messageText ifNil: [ ex printString ]).
self log: ('Drop Sequences failed for <1> with: <2>' expandMacrosWith: each name with: (ex messageText ifNil: [ ex printString ])).
Copy link
Member

@gcotelli gcotelli Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing something in the interpolation code. <1> must be <1s> and <2> must be <2s>

ex return: nil ] ]
]

Expand Down