Bump dependency: golang.org/x/[email protected]
#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2025
austin-denoble
added a commit
that referenced
this pull request
Jun 11, 2025
Dependabot opened a PR for bumping the `golang.org/x/net` dependency from 0.33.0 -> 0.38.0. However, in order to make that jump, we'd need to bump the Go version our module supports from go 1.21 -> go 1.24. For consumers, this would be a breaking change and they'd need to upgrade their version of Go to use the SDK. At the moment, I don't think is necessary for this release. For now I've updated to `golang.org/x/net v0.35.0` which is the last version which supports < `go v1.23`: - https://cs.opensource.google/go/x/net/+/refs/tags/v0.35.0:go.mod - https://cs.opensource.google/go/x/net/+/refs/tags/v0.36.0:go.mod Bump `golang.org/x/net` -> `v0.35.0`. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) CI
austin-denoble
added a commit
that referenced
this pull request
Jun 11, 2025
Dependabot opened a PR for bumping the `golang.org/x/net` dependency from 0.33.0 -> 0.38.0. However, in order to make that jump, we'd need to bump the Go version our module supports from go 1.21 -> go 1.24. For consumers, this would be a breaking change and they'd need to upgrade their version of Go to use the SDK. At the moment, I don't think is necessary for this release. For now I've updated to `golang.org/x/net v0.35.0` which is the last version which supports < `go v1.23`: - https://cs.opensource.google/go/x/net/+/refs/tags/v0.35.0:go.mod - https://cs.opensource.google/go/x/net/+/refs/tags/v0.36.0:go.mod Bump `golang.org/x/net` -> `v0.35.0`. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) CI
austin-denoble
added a commit
that referenced
this pull request
Jun 11, 2025
Dependabot opened a PR for bumping the `golang.org/x/net` dependency from 0.33.0 -> 0.38.0. However, in order to make that jump, we'd need to bump the Go version our module supports from go 1.21 -> go 1.24. For consumers, this would be a breaking change and they'd need to upgrade their version of Go to use the SDK. At the moment, I don't think is necessary for this release. For now I've updated to `golang.org/x/net v0.35.0` which is the last version which supports < `go v1.23`: - https://cs.opensource.google/go/x/net/+/refs/tags/v0.35.0:go.mod - https://cs.opensource.google/go/x/net/+/refs/tags/v0.36.0:go.mod Bump `golang.org/x/net` -> `v0.35.0`. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot opened a PR for bumping the
golang.org/x/netdependency from 0.33.0 -> 0.38.0. However, in order to make that jump, we'd need to bump the Go version our module supports from go 1.21 -> go 1.24. For consumers, this would be a breaking change and they'd need to upgrade their version of Go to use the SDK.At the moment, I don't think is necessary for this release. For now I've updated to
golang.org/x/net v0.35.0which is the last version which supports <go v1.23:Solution
Bump
golang.org/x/net->v0.35.0.Type of Change
Test Plan
CI