br: optimize memory allocation in waitUntilAllScheduleStopped

[arturmelanchyk]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• br/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

Hi @arturmelanchyk. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

Hi @arturmelanchyk. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.6848%. Comparing base (8390fc4) to head (49cd4f6).
Report is 126 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58806        +/-   ##
================================================
+ Coverage   73.4645%   74.6848%   +1.2202%     
================================================
  Files          1676       1691        +15     
  Lines        464424     463892       -532     
================================================
+ Hits         341187     346457      +5270     
+ Misses       102397      95827      -6570     
- Partials      20840      21608       +768     

Flag	Coverage Δ
integration	46.0126% <0.0000%> (?)
unit	72.3073% <0.0000%> (+0.0234%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	61.5938% <0.0000%> (+15.8735%)	⬆️

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

---

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

[arturmelanchyk]

Hi @hawkingrei
could you please look into this?

[arturmelanchyk]

@hawkingrei
just a kind reminder

[dveeden]

Hello @arturmelanchyk ,

This has the following labels set:

• do-not-merge/needs-linked-issue
• do-not-merge/needs-tests-checked

Usually we require a linked issue that describes the problem etc. For some small, technical issues we sometimes don't need this, which is indicated by the skip-issue-check label. Maybe it would be good to create an issue and link it with a short description of the problem that this PR is fixing? The title of this PR describes the solution,but not the problem.

Could you check the "Manual test" checkbox if you have done manual testing, showing that the problem is gone?

[dveeden]

Why 100? Maybe add a comment? Do you expect 100 regions per store?

[dveeden]

Is this the same 100? does it need to be kept in sync with the other 100 on line 357? If so, maybe put it in a variable.

[dveeden]

/cc @hawkingrei

[hawkingrei]

I suggest giving some benchmark data to verify the performance improvement here

[dveeden]

I suggest giving some benchmark data to verify the performance improvement here

Yes. See also https://pkg.go.dev/testing#hdr-Benchmarks