Skip to content

br: optimize memory allocation in waitUntilAllScheduleStopped #58806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arturmelanchyk wants to merge 1 commit into from
Closed

br: optimize memory allocation in waitUntilAllScheduleStopped #58806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion br/pkg/task/backup_ebs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ func waitUntilAllScheduleStopped(ctx context.Context, cfg Config, allStores []*m
defer mutex.Unlock()
allRegions = append(allRegions, regions...)
}

storeLeaderRegionsFlat := make([]*metapb.Region, 0, 100*len(allStores))
Copy link
Contributor

@dveeden dveeden Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 100? Maybe add a comment? Do you expect 100 regions per store?

for i := range allStores {
store := allStores[i]
if ectx.Err() != nil {
Expand All @@ -371,7 +373,7 @@ func waitUntilAllScheduleStopped(ctx context.Context, cfg Config, allStores []*m
return errors.Trace(err)
}

storeLeaderRegions := make([]*metapb.Region, 0, 100)
storeLeaderRegions := storeLeaderRegionsFlat[i*100 : 0 : (i+1)*100]
Copy link
Contributor

@dveeden dveeden Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same 100? does it need to be kept in sync with the other 100 on line 357? If so, maybe put it in a variable.

for {
response, err2 := checkAdminClient.Recv()
if err2 != nil {
Expand Down