Display activities with non-zero exit codes as failed #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the activity result display logic to show activities as "failing" when any command within the activity has a non-zero exit code, regardless of the overall activity result status.
- Changed
formatResultmethod signature to accept an Activity object instead of just the result string - Added logic to check command exit codes and override the result display to show failure when any command fails
- Updated all callers to pass the full Activity object to the modified method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Service/ActivityMonitor.php | Modified formatResult method to check command exit codes and override result display |
| src/Command/Integration/Activity/IntegrationActivityListCommand.php | Updated to pass Activity object to formatResult method |
| src/Command/Activity/ActivityListCommand.php | Updated to pass Activity object to formatResult method |
| src/Command/Activity/ActivityGetCommand.php | Added conditional logic to use formatResult for result property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
romainneutron
force-pushed
the
cli-activities
branch
2 times, most recently
from
3fddde1 to
7c3ef02
Compare
pjcdawkins
changed the title
romainneutron
force-pushed
the
cli-activities
branch
from
7c3ef02 to
6f82300
Compare
pjcdawkins
pushed a commit
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OBS-1229