[RECYCLE BIN] Fixes broken redirection after restoration and handle value-error gracefully if parent is deleted #4175
Conversation
| This method implements a fallback strategy: | ||
| 1. Try restored object's view URL first | ||
| 2. If that fails, try target container URL | ||
| 3. If that fails, use the recycle bin URL |
There was a problem hiding this comment.
I don't understand the strategy. What is the situation where an item was restored but we can't redirect to its view URL?
There was a problem hiding this comment.
Umm, the implementation was thought inna way:-
- try to get the
{absolute_url()}/viewbut if failing (maybe it is not available for the object) - then get the target container url but if the worst case scenario - object is broken
- then target recyclebin url...
There was a problem hiding this comment.
but if failing (maybe it is not available for the object)
This is the part I don't understand. Getting the object's absolute_url should always work. You can use restored_obj.restrictedTraverse("@@plone_context_state").view_url() to get it with the /view suffix for the content types that require that. (This comes from https://github.com/plone/plone.app.layout/blob/master/plone/app/layout/globals/context.py#L64)
There was a problem hiding this comment.
Maybe, I overcomplicated it too much... However, I have implemented a simplified based on ur suggestions in 56428b1
…and redirection after parent deletion
| This method implements a fallback strategy: | ||
| 1. Try restored object's view URL first | ||
| 2. If that fails, try target container URL | ||
| 3. If that fails, use the recycle bin URL |
There was a problem hiding this comment.
but if failing (maybe it is not available for the object)
This is the part I don't understand. Getting the object's absolute_url should always work. You can use restored_obj.restrictedTraverse("@@plone_context_state").view_url() to get it with the /view suffix for the content types that require that. (This comes from https://github.com/plone/plone.app.layout/blob/master/plone/app/layout/globals/context.py#L64)
…on by using context state
There was a problem hiding this comment.
- create a folder
- create a news page inside the same folder
- delete it
- navigate to recycleItemView and input url of other sister folder
- click restore
- get 404 error that page does not exists
- go to the sister folder
- expected: content is present but actually it is lost
fixes #4171
To-do before merging