Implement firework rocket & firework star #5455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
reviewed
Dec 19, 2022
dktapps
added
Category: Gameplay
dktapps
requested changes
May 8, 2023
Member
dktapps
left a comment
dktapps
left a comment
There was a problem hiding this comment.
The implementation looks mostly OK. I haven't tested it yet.
My main sore point on this PR is the woefully inadequate documentation and ambiguous method names.
![pmmp-admin-bot[bot]](https://avatars.githubusercontent.com/in/1059952?s=60&v=4){kind=small}
kostamax27
reviewed
Sep 20, 2025
with Java, anyway
dktapps
approved these changes
Sep 20, 2025
IvanCraft623
commented
Sep 22, 2025
| for($i = 0; $i < 2; $i++){ | ||
| $target = $position->add(0, 0.5 * $i * $height, 0); | ||
| foreach(VoxelRayTrace::betweenPoints($this->location, $target) as $blockPos){ | ||
| if($world->getBlock($blockPos)->calculateIntercept($this->location, $target) !== null){ |
Member
Author
There was a problem hiding this comment.
Dont remember exactly but pretty sure that i compared with isSolid bc it covered most cases, for example damage should be done anyways if there is any flowable block
Member
There was a problem hiding this comment.
The old check didn't line up with Java when I compared. It didn't make much sense to me for the likes of signs to prevent firework damage.
Member
There was a problem hiding this comment.
isSolid is also deprecated and returns false for flowables so that wouldn't have done what you wanted either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Implement items:
Firework Rocket,Firework Starand entity:Firework Rocket.Follow-up
Requires translations:
death.attack.fireworks{%0} went off with a bangTests
https://youtu.be/kHs_nBmLRhs