-
Notifications
You must be signed in to change notification settings - Fork 20
💡[Feature]: Create one task for bundle & package each (Fix - 386) #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡[Feature]: Create one task for bundle & package each (Fix - 386) #397
Conversation
Hey @Adam-it @nicodecleyre, Have just pushed this. Thanks, |
Awesome work. I will try to have a look and do the review early next week. |
Awesome, thank you for your contribution 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NishkalankBezawada Awesome work so far 👏
I left a few minor comments we could sort out before we merge.
I tested it locally and works perfectly. When testing I noticed a small bug but I will open a separate issue for that as it is not related to your change.
You Rock 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awsome work 👏👏👏
I added a small fixup
🎯 Aim
Currently there are 2 tasks for bundle & package each. Namely:
Bundle (local)
Bundle (production)
for the bundle task, and:
Package (local)
Package (production)
With this, We achieve to create one task for bundle project. When clicked on
Bundle project
, a prompt is shown with optionslocal
andproduction
. Depending on the user selection, the command is executed in the terminal.📷 Result for Bundle task
Below is for local, executing
gulp bundle
Below is for production, executing
gulp bundle --ship
📷 Result for Package task
Below is for both Package local and package production, executing
gulp package-solution
&gulp package-solution --ship
✅ What was done
Added a two new methods in
TerminalCommandExecuter
with namebundleProject
&packageProject
, which will execute this.🔗 Related issue
Closes: #386