Skip to content

💡[Feature]: Create one task for bundle & package each (Fix - 386) #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NishkalankBezawada
Copy link
Contributor

@NishkalankBezawada NishkalankBezawada commented Jan 24, 2025

🎯 Aim

Currently there are 2 tasks for bundle & package each. Namely:

Bundle (local)
Bundle (production)
for the bundle task, and:
Package (local)
Package (production)

With this, We achieve to create one task for bundle project. When clicked on Bundle project, a prompt is shown with options local and production. Depending on the user selection, the command is executed in the terminal.

📷 Result for Bundle task

Below is for local, executing gulp bundle

Untitled+video+(27)

Below is for production, executing gulp bundle --ship

Untitled+video+(28)

📷 Result for Package task

Below is for both Package local and package production, executing gulp package-solution & gulp package-solution --ship

Untitled+video+(30)

✅ What was done

Added a two new methods in TerminalCommandExecuter with name bundleProject & packageProject, which will execute this.

image
  • done

🔗 Related issue

each PR should be linked with a related issue [Remove this line]

Closes: #386

@NishkalankBezawada NishkalankBezawada marked this pull request as draft January 24, 2025 16:02
@NishkalankBezawada NishkalankBezawada changed the title Create one task for bundle project 💡[Feature]: Create one task for bundle & package each (Fix - 386) Jan 24, 2025
@NishkalankBezawada NishkalankBezawada marked this pull request as ready for review January 24, 2025 16:23
@NishkalankBezawada
Copy link
Contributor Author

Hey @Adam-it @nicodecleyre,

Have just pushed this.

Thanks,
Nish

@Adam-it
Copy link
Member

Adam-it commented Jan 24, 2025

Hey @Adam-it @nicodecleyre,

Have just pushed this.

Thanks,
Nish

Awesome work. I will try to have a look and do the review early next week.

@nicodecleyre
Copy link
Contributor

Hey @Adam-it @nicodecleyre,

Have just pushed this.

Thanks,
Nish

Awesome, thank you for your contribution 🤩

Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NishkalankBezawada Awesome work so far 👏
I left a few minor comments we could sort out before we merge.
I tested it locally and works perfectly. When testing I noticed a small bug but I will open a separate issue for that as it is not related to your change.

You Rock 🤩

@Adam-it Adam-it marked this pull request as draft January 29, 2025 23:51
@NishkalankBezawada NishkalankBezawada marked this pull request as ready for review January 30, 2025 12:11
Adam-it
Adam-it previously approved these changes Feb 3, 2025
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome work 👏👏👏
I added a small fixup

@Adam-it Adam-it linked an issue Feb 3, 2025 that may be closed by this pull request
@Adam-it Adam-it merged commit cea0a3a into pnp:dev Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [Feature]: Create one task for bundle & package each
3 participants