Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Game modifier/Target Practice stub #10305

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Extend Game modifier/Target Practice stub #10305

merged 14 commits into from
Feb 27, 2024

Conversation

CloneWith
Copy link
Contributor

@CloneWith CloneWith commented Oct 28, 2023 •
edited
Loading

Self-check

@osu-wiki-observatory osu-wiki-observatory bot mentioned this pull request Oct 28, 2023
Merged
2 tasks
@agatemosu
Copy link
Contributor

agatemosu commented Oct 28, 2023 •
edited
Loading

pull master before the first commit xd, spanish has been added in those 1021 commits

@TicClick TicClick self-requested a review November 22, 2023 21:26
peppy
peppy requested changes Dec 5, 2023
View reviewed changes
wiki/Gameplay/Game_modifier/Target_Practice/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Target_Practice/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Target_Practice/en.md Outdated Show resolved Hide resolved
@osu-wiki-observatory osu-wiki-observatory bot mentioned this pull request Dec 28, 2023
Merged
2 tasks
@TicClick TicClick mentioned this pull request Jan 26, 2024
Merged
TicClick
TicClick previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it upon myself to help with the rewrite and small cleanup, so I'll let someone else proofread my changes1

Footnotes

  1. (of which I quietly approve) ↩

@TicClick TicClick requested a review from peppy January 26, 2024 13:02
Walavouchey
Walavouchey requested changes Feb 27, 2024
View reviewed changes
wiki/Gameplay/Game_modifier/Target_Practice/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Target_Practice/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Target_Practice/en.md Outdated Show resolved Hide resolved
@Walavouchey Walavouchey merged commit 0fcf89d into ppy:master Feb 27, 2024
3 checks passed
@CloneWith CloneWith deleted the Patch-Mod+ branch February 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Walavouchey Walavouchey Walavouchey approved these changes

@peppy peppy peppy approved these changes

@TicClick TicClick TicClick left review comments

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CloneWith @agatemosu @peppy @TicClick @Walavouchey