Core: Transition PAAPI parameters #3670
Conversation
# Conflicts: # src/main/java/org/prebid/server/handler/SetuidHandler.java
|
|
||
| final boolean shouldDropIgb = StringUtils.isEmpty(igi.getImpid()); | ||
| if (shouldDropIgb) { | ||
| conditionalLogger.warn("ExtIgi with absent impId from bidder: " + bidder, logSamplingRate); |
There was a problem hiding this comment.
I've noticed the requirement to emit warning in debug mode, shouldn't we add the warning messages to the response?
| /** | ||
| * Restores ONLY imps from rejection, rejected bids are preserved for analytics. | ||
| * A bid can be rejected only once. | ||
| */ |
There was a problem hiding this comment.
please keep these comments)
There was a problem hiding this comment.
We don't comment code. Only in super tricky situations, which is not the case.
| .fledgeAuctionConfigs(extractFledge(bidResponse)) | ||
| .errors(bidderErrors) | ||
| .bids(extractBids(bidRequest, bidResponse, errors)) | ||
| .igi(extractIgi(bidResponse)) |
There was a problem hiding this comment.
I'm not sure about other exchanges' cases, but changing the existing contract of the IX bid response for PAAPI will immediately break the current PBS-Index integration. Index does not yet support the community extension for Protected Audience, which defines naming and structure differently from Google's defined format.
I assumed that any new implementation would be done separately to ensure backward compatibility with the current integration (i.e., still supporting the older format).
There was a problem hiding this comment.
Its not breaking change. What I have done:
- I have rewritten all bidders to supply PBS with new PA format.
- Added ability to convert new PA format to old Fledge format.
Index does not need to support new PA extensions right now. You can configure output format (old/new) and by default it will respond with old format. Check this out: prebid/prebid-server#3536 (comment)
There was a problem hiding this comment.
I see.
In the integration test for IX, I I noticed that the protectedAudienceAuctionConfigs field was removed from Bid response src/test/resources/org/prebid/server/it/openrtb2/ix/test-ix-bid-response.json and thus I assumed the new implementation no longer supports the older format returned by the exchange. That should still work as it is. Could you please restore it?
There was a problem hiding this comment.
We don't test this kind of stuff in integration tests. We use them as sanity check (basically, only happy path is tested here). All bidder functionality is covered by unit tests. That's why I removed this.
It's an oversight from a reviewer, who approved this in a first place.
Conversion from Paa format to fledge will be covered with functional tests.
There was a problem hiding this comment.
Ah, I see your point. I found the integration test useful as a quick reference for understanding the expected Exchange response format and ensuring the Adapter handles it correctly. Functional test doesn't give that quick overview (no raw json handling). However, if you say the policy is to keep integration tests very basic, I'll align with that.
On the IX side, I built and ran some internal end-to-end tests on top of your changes, and I can confirm everything works as expected. 👍
| } | ||
|
|
||
| final ExtIgiIgs preparedExtIgiIgs = extIgiIgs.toBuilder() | ||
| .ext(ExtIgiIgsExt.of(bidder, bidderCatalog.resolveBaseBidder(bidder))) |
There was a problem hiding this comment.
As I see, bidder can be an alias at the request level, so we need to resolve that mapping first.
| final boolean extIgsAePresent = Optional.ofNullable(ext) | ||
| .map(extNode -> extNode.get(EXT_IGS)) | ||
| .filter(JsonNode::isArray) | ||
| .map(extNode -> StreamSupport.stream(extNode.spliterator(), false).toList()) | ||
| .stream() | ||
| .flatMap(Collection::stream) | ||
| .filter(Objects::nonNull) | ||
| .anyMatch(igsElementNode -> igsElementNode.has(EXT_AE)); |
There was a problem hiding this comment.
final boolean extIgsAePresent = Optional.ofNullable(ext)
.map(extNode -> extNode.get(EXT_IGS))
.filter(JsonNode::isArray)
.stream()
.flatMap(extNode -> StreamUtil.asStream(extNode.spliterator()))
.filter(Objects::nonNull)
.anyMatch(igsElementNode -> igsElementNode.has(EXT_AE));
| /** | ||
| * Defines the contract for bidresponse.ext.igi | ||
| */ | ||
| @Builder(toBuilder = true) |
There was a problem hiding this comment.
I'm not sure that we want to use builder for objects with 3 properties, remove it if you don't mind.
| import lombok.Builder; | ||
| import lombok.Value; | ||
|
|
||
| @Builder(toBuilder = true) |
🔧 Type of changes
✨ What's the context?
prebid/prebid-server#3536
🔎 New Bid Adapter Checklist
🧪 Test plan
Unit tests + functional tests
🏎 Quality check