-
Notifications
You must be signed in to change notification settings - Fork 220
Core: Transition PAAPI parameters #3670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1810e87
Added new PAA iab model.
And1sS abd3104
PAA WIP.
And1sS ebfa6df
Refactoring.
And1sS e4a45ef
Refactoring.
And1sS 824d279
Refactoring.
And1sS 4b60b51
Partly fixed unit tests.
And1sS 5bf42c6
Fixed unit tests.
And1sS 81d8c77
Added unit tests for BidResponseCreator and HttpBidderRequester
And1sS 5d6d88b
Added igs.ae mapping.
And1sS 4ca36ba
Removed TODOs.
And1sS 9e492ba
Fixed styling.
And1sS 8333f7c
Fixed naming.
And1sS 9292540
Merge branch 'master' into feature/paa
And1sS b0c7f31
Fixes after merging master
And1sS 85208f5
Fixed IxTest.
And1sS 3882deb
Made paa format default to original.
And1sS 0841723
Added missing validations.
And1sS 032f15f
Fixed inconsistent unit test.
And1sS 5163003
Merge branch 'master' into feature/paa
And1sS 7fd613e
Fixed igi validations.
And1sS bfffd2f
Fixed styling.
And1sS d5d45c3
Added bidRequest level alias resolving and response level debug warni…
And1sS c466359
Refactored ImpAdjuster.
And1sS ce1d57f
Now paa debug warnings utilize debugEnabled flag.
And1sS d16a64b
Added metrics.
And1sS 7ea648e
Test: `Transition PAAPI parameters` (#3634)
marki1an 77df115
Merge branch 'refs/heads/master' into feature/paa
osulzhenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
201 changes: 185 additions & 16 deletions
201
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/main/java/org/prebid/server/auction/model/PaaFormat.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package org.prebid.server.auction.model; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| public enum PaaFormat { | ||
|
|
||
| @JsonProperty("original") | ||
| ORIGINAL, | ||
|
|
||
| @JsonProperty("iab") | ||
| IAB | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
src/main/java/org/prebid/server/bidder/criteo/CriteoExtBidResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| package org.prebid.server.bidder.criteo; | ||
|
|
||
| import lombok.Value; | ||
| import org.prebid.server.proto.openrtb.ext.response.ExtIgi; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| @Value(staticConstructor = "of") | ||
| public class CriteoExtBidResponse { | ||
|
|
||
| List<CriteoIgiExtBidResponse> igi; | ||
| List<ExtIgi> igi; | ||
| } |
13 changes: 0 additions & 13 deletions
13
src/main/java/org/prebid/server/bidder/criteo/CriteoIgiExtBidResponse.java
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
src/main/java/org/prebid/server/bidder/criteo/CriteoIgsIgiExtBidResponse.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.