Prebuilding for multiple target does not work with 6.0.1 #90
Comments
|
This also happens on linux, and not with It seems, that what happens is: In And in It seems that they added the name, and forgot to add the other tags to the final name 🤷🏼♂️ |
Totto16
added a commit
to Totto16/prebuildify
that referenced
this issue
May 27, 2024
- add test, that uses "real worlds scenario" by using really parsed options, not just artificially generated options - to make this tests possible, I had to factor the function, that parses teh args out, and make a separate file
This was referenced May 27, 2024
NorthernMan54
added a commit
to homebridge/node-pty-prebuilt-multiarch
that referenced
this issue
May 27, 2024
NorthernMan54
added a commit
to homebridge/node-pty-prebuilt-multiarch
that referenced
this issue
Jun 7, 2024
* Update to NAN 2.19.0 - better support for Electron 29 * feat: support node abi 127 (Node v22) (#43) * update `README` * feat: support node abi 127 (Node v22) Fixes #42 --------- Co-authored-by: Ben <[email protected]> Co-authored-by: Northern Man <[email protected]> * Build updates for warning messages * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * drop older versions * Fix MacOS Arm Build * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * ModuleNotFoundError: No module named 'distutils' * Reduce warning messages * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * Update Prepare prebuild environment.yml * Update dependencies * Update Prepare prebuild environment.yml * Rollback for this issue - prebuild/prebuildify#90 prebuild/prebuildify#90 * Update README.md --------- Co-authored-by: Steffen Neubauer <[email protected]> Co-authored-by: Ben <[email protected]>
|
I just tested the fix in #91 and it worked as expected for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use prebuildify to prebuild for the target environments that we use and execute it something like this:
With version 5.0.1 this resulted in 3 prebuilds with the names:
After upgrading to 6.0.1 we only get 1 prebuild with the name:
my-package-name.node. This means the prebuild will only work in some environments and error in others. Prebuildify still runs three builds but I assume only the last one is available in the builds folder. Platform is Windows if that matters.The text was updated successfully, but these errors were encountered: