Correctly handle Override of napi on manually specifying targets #91
+67
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add test, that uses "real worlds scenario" by using really parsed options, not just artificially generated options - to make this tests possible, I had to factor the function, that parses teh args out, and make a separate file
Author
No clue 🤷🏼♂️ |
|
I've read a comment from one of the dev, it seems you only need to support the lowest version of Node you need and Node-API will provide forward-compatibility for any future version |
Member
|
I don't think we need this PR, you can already pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
add test, that uses "real worlds scenario" by using really parsed options, not just artificially generated options
to make this tests possible, I had to factor the function, that parses the args out, and make a separate file
the fix was relative simple, see here
The rest just refactors the files, to be able to test this, and have no regressions in the future