fix: respect case sensitivity of filesystem when collecting new files#1699
Merged
wolfv merged 9 commits intoprefix-dev:mainfrom Jun 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1375
The issue boils down to the fact that the filesystem on Windows is case-insensitive (
foobar.txt == FOOBAR.txt) but path comparison in Rust is not case-insensitive. Or maybe, to be more precise, case-preserving while being case-insensitive.So we sometimes detected a file as new, even though it matched an existing file (just different casing of the parent directory).