[vs20xx] Fix flags { "LinkTimeOptimization" } to add missing xml entity LinkTimeCodeGeneration
#2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tity `LinkTimeCodeGeneration`
StanleySweet
approved these changes
Oct 28, 2024
tritao
approved these changes
Oct 28, 2024
nickclark2016
approved these changes
Oct 30, 2024
Member
|
Future Note: We should add this as a dedicated API member and deprecate the flag. |
noresources
pushed a commit
to depinxi/premake-core
that referenced
this pull request
Nov 8, 2024
…tity `LinkTimeCodeGeneration` (premake#2313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
flags { "LinkTimeOptimization" }to add missing xml entityLinkTimeCodeGeneration.How does this PR change Premake's behavior?
Generated visual solutions with
flags { "LinkTimeOptimization" }would be modifiedAnything else we should know?
@StanleySweet Can you verify it fix your issue.
closes #2312
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)