Skip to content

[vs20xx] Fix flags { "LinkTimeOptimization" } to add missing xml entity LinkTimeCodeGeneration #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[vs20xx] Fix flags { "LinkTimeOptimization" } to add missing xml entity LinkTimeCodeGeneration #2313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/vstudio/vs2010_vcxproj.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,13 +675,15 @@
m.fullProgramDatabaseFile,
m.generateDebugInformation,
m.optimizeReferences,
m.LinkTimeCodeGeneration,
}
else
return {
m.subSystem,
m.fullProgramDatabaseFile,
m.generateDebugInformation,
m.optimizeReferences,
m.LinkTimeCodeGeneration,
m.additionalDependencies,
m.additionalLibraryDirectories,
m.importLibrary,
Expand Down Expand Up @@ -2727,6 +2729,11 @@
end
end

function m.LinkTimeCodeGeneration(cfg)
if cfg.flags.LinkTimeOptimization then
m.element("LinkTimeCodeGeneration", nil, "UseLinkTimeCodeGeneration")
end
end

function m.optimization(cfg, condition)
local map = { Off="Disabled", On="Full", Debug="Disabled", Full="Full", Size="MinSpace", Speed="MaxSpeed" }
Expand Down
3 changes: 2 additions & 1 deletion src/base/config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@
function config.canLinkIncremental(cfg)
if cfg.kind == "StaticLib"
or config.isOptimizedBuild(cfg)
or cfg.flags.NoIncrementalLink then
or cfg.flags.NoIncrementalLink
or cfg.flags.LinkTimeOptimization then
return false
end
return true
Expand Down