Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionList sub components) Convert to CSS Modules #5398

Merged
merged 61 commits into from
Dec 18, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Dec 7, 2024

Closes https://github.com/github/primer/issues/3961

👉 Please make sure to review this collapsed file as its probably the most important one: Item

Converts the following ActionList components:

  • Description
  • Group
  • Item
  • LinkItem
  • Selection
  • TrailingAction
  • Visuals

VRT

There are some visual changes and bug fixes that were only possible to make in this giant PR. Sorry in advance 😄 I will showcase them below since the PR is large and won't render all images.

before after what changed
image image inactive icon misaligned
image image divider width
image image extremely tiny padding change
image image item text size bug fix

I have also made the decision to remove a specific VRT test that fails between default and enabled. The failure is likely due to a flex vs grid layout and very minor, and it's not something I can easily "fix" in default. I'm willing to take the risk here.

CleanShot.2024-12-11.at.12.06.59.mp4

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 7, 2024

🦋 Changeset detected

Latest commit: 82be5a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 7, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5398 December 7, 2024 00:29 Inactive
Copy link
Contributor

github-actions bot commented Dec 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.05 KB (+0.7% 🔺)
packages/react/dist/browser.umd.js 104.53 KB (+0.83% 🔺)

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 18, 2024
Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a small difference with trailing visuals in the Link Item story

Screen capture of the ActionList component with links. Shown are multiple action list link items, and a trailing visual on the last item. The trailing visual is stacked vertically rather than horizontally

It looks like this is due to the display: grid being attached on the container of the items (. ActionListSubContent) rather than display: flex, I think 🤔

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed update snapshots integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 18, 2024
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@langermank langermank added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@langermank langermank added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 215d8e6 Dec 18, 2024
42 checks passed
@langermank langermank deleted the al-trailingaction-css branch December 18, 2024 22:44
@primer primer bot mentioned this pull request Dec 18, 2024
francinelucca added a commit that referenced this pull request Jan 9, 2025
francinelucca added a commit that referenced this pull request Jan 9, 2025
francinelucca added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants