Skip to content

chore: update storybook config to work with local dev #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented May 29, 2025

Add host.docker.internal to list of approved hosts when developing locally. This addresses an issue when using script/test-e2e locally.

Copy link

changeset-bot bot commented May 29, 2025

⚠️ No Changeset found

Latest commit: dbf548a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 29, 2025
Copy link
Contributor

github-actions bot commented May 29, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.53 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 94.63 KB (+0.11% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-6142 May 29, 2025 19:51 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label May 30, 2025
@joshblack joshblack marked this pull request as ready for review May 30, 2025 16:48
@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 16:48
@joshblack joshblack requested a review from a team as a code owner May 30, 2025 16:48
@joshblack joshblack requested a review from TylerJDev May 30, 2025 16:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Storybook configuration to allow host.docker.internal when running locally.

  • Adds a conditional block for DEPLOY_ENV === 'development' that sets config.server.allowedHosts.
  • Introduces host.docker.internal alongside a misspelled locahost.

if (DEPLOY_ENV === 'development') {
config.server = {
...config.server,
allowedHosts: ['locahost', 'host.docker.internal'],
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider merging this array with any existing config.server.allowedHosts to avoid overwriting other allowed hosts, e.g.: allowedHosts: [...(config.server.allowedHosts ?? []), 'localhost', 'host.docker.internal'].

Suggested change
allowedHosts: ['locahost', 'host.docker.internal'],
allowedHosts: [...(config.server.allowedHosts ?? []), 'localhost', 'host.docker.internal'],

Copilot uses AI. Check for mistakes.

@joshblack joshblack added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit bb960fd May 30, 2025
35 checks passed
@joshblack joshblack deleted the fix/update-storybook-config-for-local-e2e-tests branch May 30, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants