[Python] fixed subscription crash #32257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
|
@tianfeng-yang I would suggest to use ShutdownSubscriptions from https://github.com/project-chip/connectedhomeip/blob/master/src/app/InteractionModelEngine.cpp#L296, and remove abort API. and leave the below unchanged. |
Changing the API like this is a bit extensive, and I can't confirm whether it will cause a chain reaction. |
tianfeng-yang
force-pushed
the
fix/python-subscripiton
branch
from
1de5de0
to
a629204
Compare
|
PR #32257: Size comparison from a629204 to e10817e Full report (20 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #32257: Size comparison from a629204 to d5f2d56 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
NOTE on old PR staleness review: this PR seems to be under active development and could use some reviews. |
tcarmelveilleux
approved these changes
Oct 11, 2024
yunhanw-google
approved these changes
Oct 11, 2024
arkq
approved these changes
Oct 14, 2024
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
Oct 16, 2024
This reverts commit dcb4444.
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
Oct 16, 2024
This reimplements project-chip#32257 without reformatting Python files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #32310
ReadClientlife cycle isOnDone. IfOnErrorhappend,OnDonewill eventually be executed. In the existing Python code,delete itis executed inOnDone. At this time,pCallbackandpReadClient(moved frompychip_ReadClient_Read) have both been deleted. , After that, if the python application executesSubscriptionTransaction.Shutdown()ordelete,pychip_ReadClient_Abortwill be executed, which will causepCallbackto be deleted again, causing the application to crash. Therefore, when callingShuddown()ordeleteon the python side, you need to determine whetherOnErrorhappend. IfOnErrorhappend, you do not need to callpychip_ReadClient_Abortagain. If not, it is a normal delete behavior on the application side.ReadClientalso describes that after deletingReadClient,OnDonewill not be executed, so we can directly deleteReadClientin the callback ofOnDone(the life cycle ofReadClienthas ended), so that there is no need to move the memory ofpReadClienttoReadClientCallbackinpychip_ReadClient_Read.@notes: There is no problem moving
ReadClienttopCallbackhere, butWriteClientCallbackis also not moved, just for consistency reasons.Follow the advice
The following two points are split into PR #32308
chip-toolGetSubscriptionTimeoutMsinterface to check if the subscription is alive.