BDX transfer support for Python tests #34821
Open
+1,244
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
github-actions
bot
added
controller
matter-1.4-te2-script-change
|
PR #34821: Size comparison from 83dc1c8 to 5a28be5 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
* Rename TransferData to TransferInfo. * Change `!=` to `is not` in python. * Add missing type annotation.
harimau-qirex
force-pushed
the
bdx-python-api
branch
from
32d5755
to
0d90892
Compare
Also remove an unnecessary conversion to bytearray.
|
PR #34821: Size comparison from 0454504 to 69d4db7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
reviewed
Nov 8, 2024
andy31415
approved these changes
Nov 8, 2024
Also: * Split the accept function into one for sending data and one for receiving data. * Return bytes instead of a bytearray when receiving data. * Add typing to the data callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for BDX transfers to the Python tests.
This allows Python tests to wait for BDX transfers, inspect the init message's details, accept or reject the transfer, and send or receive data. This assists with writing tests for the OTA requestor and diagnostic logs clusters that involve BDX transfers. The code takes some inspiration from the existing BDX transfer server code in src/protocols/bdx, and I think it's worth following up at some point to expand the capabilities of that code to reduce the amount of code specific to the Python controller code introduced in this change.
Included is a test that uses the diagnostic logs cluster on the all clusters app to initiate and complete a BDX transfer.