Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDX transfer support for Python tests #34821

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

BDX transfer support for Python tests #34821

wants to merge 55 commits into from
+1,244 −0

Commits on Nov 7, 2024

  1. Add the python-C++ translation.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    281d8e2 View commit details
    Browse the repository at this point in the history

  2. Add a BDX transfer server to handle unsolicited BDX init messages.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1d17e6c View commit details
    Browse the repository at this point in the history

  3. Add the manager to implement the transfer pool.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8832ed9 View commit details
    Browse the repository at this point in the history

  4. Add the initial implementation of a BDX transfer.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d8cce79 View commit details
    Browse the repository at this point in the history

  5. Use BdxTransfer in the other classes.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0f92e4d View commit details
    Browse the repository at this point in the history

  6. Update constructors to set the delegates etc. correctly.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1b9b9d4 View commit details
    Browse the repository at this point in the history

  7. Implement the C++ side of the barrier. Move the data callback into th… 

    …e transfer delegate.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    39ca533 View commit details
    Browse the repository at this point in the history

  8. Add a way to map the transfer to the python contexts.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d330e72 View commit details
    Browse the repository at this point in the history

  9. Fix some of the minor TODOs.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    837d30a View commit details
    Browse the repository at this point in the history

  10. Add init/shutdown to the transfer server.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c50590f View commit details
    Browse the repository at this point in the history

  11. Start on the implementation of the Python side. 

    Also add the transfer obtained context to the C++ methods relating to expecting transfers.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e4ea82a View commit details
    Browse the repository at this point in the history

  12. Listen for all BDX protocol messages rather than just the init messages.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6eaa9ac View commit details
    Browse the repository at this point in the history

  13. Fix minor issues in the transfer server.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c15f43d View commit details
    Browse the repository at this point in the history

  14. Implement a good chunk of the python side.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d2fe4d0 View commit details
    Browse the repository at this point in the history

  15. Fix compile errors.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4e5bb67 View commit details
    Browse the repository at this point in the history

  16. Fix a number of issues preventing the BDX python code from running at… 

    … all.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7c458b4 View commit details
    Browse the repository at this point in the history

  17. Return the results of the python-C methods.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    614bafd View commit details
    Browse the repository at this point in the history

  18. Fix the async-ness of the methods that prepare the system to receive … 

    …a BDX transfer.

Also run the python BDX initialisation.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2a62e8a View commit details
    Browse the repository at this point in the history

  19. Initialise the BDX transfer server. 

    Also ignore the BDX transfer server implementation that only handles diagnostic logs.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fee179b View commit details
    Browse the repository at this point in the history

  20. Fixes necessary to await on the future from PrepareToReceive/SendBdxD… 

    …ata.

* Call Responder::PrepareForTransfer from BdxTransfer.
* Correctly schedule satisfying the future on the event loop.
* Use the real property to determine if a PyChipError was a success.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    bac4a10 View commit details
    Browse the repository at this point in the history

  21. Fix sending the accept message.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0f16585 View commit details
    Browse the repository at this point in the history

  22. Acknowledge received blocks so the BDX transfer continues. 

    Also don't ignore all messages after the init.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    175c347 View commit details
    Browse the repository at this point in the history

  23. Fix the parameters of the python callback methods.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a67f783 View commit details
    Browse the repository at this point in the history

  24. Add another async transaction class to handle the transfer completed … 

    …callback.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b114126 View commit details
    Browse the repository at this point in the history

  25. Add comments to the C++ code.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a5b115d View commit details
    Browse the repository at this point in the history

  26. Add a test for the BDX transfer that uses the diagnostic logs cluster.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a345c55 View commit details
    Browse the repository at this point in the history

  27. Move the calls to release a transfer out of the manager so it works t… 

    …he way one would expect.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4e0fb49 View commit details
    Browse the repository at this point in the history

  28. Delay releasing the C++ BDX transfer object until after it's no longe… 

    …r in use.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dec62e9 View commit details
    Browse the repository at this point in the history

  29. Verify the diagnostic logs response is a success.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2670d2d View commit details
    Browse the repository at this point in the history

  30. Restyled by whitespace

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4049521 View commit details
    Browse the repository at this point in the history

  31. Restyled by clang-format

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e64362d View commit details
    Browse the repository at this point in the history

  32. Restyled by gn

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4129083 View commit details
    Browse the repository at this point in the history

  33. Restyled by autopep8

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8bfde70 View commit details
    Browse the repository at this point in the history

  34. Restyled by isort

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e10ed98 View commit details
    Browse the repository at this point in the history

  35. Improve BdxTransferManager's comments.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    de8c8a5 View commit details
    Browse the repository at this point in the history

  36. Use a vector for the data to send over a BDX transfer rather than a r… 

    …aw pointer.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    453afaa View commit details
    Browse the repository at this point in the history

  37. Minor renames.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d618ec3 View commit details
    Browse the repository at this point in the history

  38. Improve the error message when the BDX transfer pool is exhausted.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2148873 View commit details
    Browse the repository at this point in the history

  39. Minor fixes. 

    * remove a check that was inadvertently kept.
* print a log message when something that shouldn't happen inevitably does.
* use user_params to get the end user support log test parameter.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    36ee48f View commit details
    Browse the repository at this point in the history

  40. Pass the status report's status code up the stack.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4423da6 View commit details
    Browse the repository at this point in the history

  41. Merge the BDX transfer server into the manager.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    37a9721 View commit details
    Browse the repository at this point in the history

  42. Rename BdxTransferManager to TestBdxTransferServer.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fdb9bcc View commit details
    Browse the repository at this point in the history

  43. Minor cleanup. 

    * Rename TransferData to TransferInfo.
* Change `!=` to `is not` in python.
* Add missing type annotation.
    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7d62ba8 View commit details
    Browse the repository at this point in the history

  44. Improve the documentation of the ownership in the C++ side.

    @harimau-qirex
    harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3b4d586 View commit details
    Browse the repository at this point in the history

  45. Restyled by clang-format

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1ab7896 View commit details
    Browse the repository at this point in the history

  46. Restyled by autopep8

    @restyled-commits @harimau-qirex
    restyled-commits authored and harimau-qirex committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0d90892 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Update the new test to work with the new formatting. 

    Also remove an unnecessary conversion to bytearray.
    @harimau-qirex
    harimau-qirex committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2c4704a View commit details
    Browse the repository at this point in the history

  2. Lint fixes.

    @harimau-qirex
    harimau-qirex committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    69d4db7 View commit details
    Browse the repository at this point in the history

  3. Fix clang-tidy errors.

    @harimau-qirex
    harimau-qirex committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0b52760 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Several fixes suggested by Andrei.

    @harimau-qirex
    harimau-qirex committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8c23dc2 View commit details
    Browse the repository at this point in the history

  2. Fix a name in a comment.

    @harimau-qirex
    harimau-qirex committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e94fd49 View commit details
    Browse the repository at this point in the history

  3. Fix issues preventing test from working. 

    Also:
* Split the accept function into one for sending data and one for receiving data.
* Return bytes instead of a bytearray when receiving data.
* Add typing to the data callback.
    @harimau-qirex
    harimau-qirex committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fb1a231 View commit details
    Browse the repository at this point in the history

  4. Rename the methods that accept transfers so it's clear which way the … 

    …data is flowing.
    @harimau-qirex
    harimau-qirex committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c092c64 View commit details
    Browse the repository at this point in the history

  5. Add doc comments to the Python classes and methods.

    @harimau-qirex
    harimau-qirex committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ea73b94 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Fix issues found by mypy.

    @harimau-qirex
    harimau-qirex committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3f9372a View commit details
    Browse the repository at this point in the history