Return nil instead of an empty string from normalized_date #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
force-pushed
the
fix-nil-date-normalize
branch
4 times, most recently
from
e3fca07
to
cc6b528
Compare
corylown
changed the title
corylown
force-pushed
the
fix-nil-date-normalize
branch
from
cc6b528
to
243d7a5
Compare
seanaery
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArcLight 1.1 is indexing empty strings in
normalized_date_ssmif the normalization process results in no normalized values for any of the various date types. The downstream effect is the UI displays labels without values where thenormalized_date_ssmfield is configured to display.Changes to date normalization changed this behavior (and the test) here: 3eb358b
Before this change:
After this change:
