Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nil instead of an empty string from normalized_date #1513

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Return nil instead of an empty string from normalized_date #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/arclight/normalized_date.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def normalize
result << inclusive if inclusive.present?
result << other if other.present?
result << "bulk #{bulk}" if bulk.present?
result.compact.map(&:strip).join(', ')
result.compact.map(&:strip).join(', ').presence
end
end
end
2 changes: 1 addition & 1 deletion spec/lib/arclight/normalized_date_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
let(:date_other) { nil }

it 'does not know what to do' do
expect(normalized_date).to eq ''
expect(normalized_date).to be_nil
end
end
end
Expand Down
Loading