Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch React 15 warnings #155

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Patch React 15 warnings #155

wants to merge 3 commits into from

Conversation

ifunk
Copy link
Contributor

@ifunk ifunk commented Jan 20, 2017

Fixes this warning (#150) when value for input is undefined or null by using an empty string for value when required.

A component is changing a controlled input of type text to be uncontrolled.
Input elements should not switch from controlled to uncontrolled (or vice versa).
Decide between using a controlled or uncontrolled input element for the
lifetime of the component. More info: https://fb.me/react-controlled-components

Fixes this warning by removing known keys from spreaded props.

Warning: Unknown props `stylesheet`, `formValue` on <form> tag.
Remove these props from the element. For details, see https://fb.me/react-unknown-prop

@ifunk
Copy link
Contributor Author

ifunk commented Jan 20, 2017

I should note preventing spreading of props might be a breaking change for people who are passing through a component for Fieldset instead of a dom string, but they should be able to refactor their code to use Fieldset directly inside their component instead.

@digitalkaoz
Copy link

any chance this gets merged?

@akomm
Copy link

akomm commented Mar 8, 2017

Would appreciate if you could merge it

@nightwolfz
Copy link

Pretty please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants