Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch React 15 warnings #155

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Patch React 15 warnings #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49c752f
Only spread props that we are not using in this component (and super …
adamroyle Jan 20, 2017
c8b92a9
Prevent React 15.4 warning about uncontrolled -> controlled inputs.
adamroyle Jan 20, 2017
8197225
Prevent React 15.4 warning about spreading unknown props on dom eleme…
adamroyle Jan 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ErrorList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export default class ErrorList extends Component {
});

render() {
let {
noLabel, hideNonForced, complete, schemaType, stylesheet,
// eslint-disable-next-line no-unused-vars
let { noLabel, hideNonForced, complete, schemaType, stylesheet, formValue, select, label,
...props
} = this.props;
let {Root, Error} = stylesheet || this.constructor.stylesheet;
Expand Down
4 changes: 3 additions & 1 deletion src/Fieldset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export default class Fieldset extends Component {

render() {
let {Root} = this.props.stylesheet || this.constructor.stylesheet;
return <Root {...this.props} />;
// eslint-disable-next-line no-unused-vars
let {stylesheet, formValue, select, selectFormValue, ...props} = this.props;
return <Root {...props} />;
}
}
3 changes: 3 additions & 0 deletions src/Input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export default class Input extends React.Component {
if (debounceEnabled) {
value = this.state.value;
}
if (Component === 'input' && (value === undefined || value === null)) {
value = '';
}
return (
<Component
{...props}
Expand Down