Fix #4: make buildable on Mac OS / with Clang #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkapiLib did not build on all systems due to not-officially-supported idioms and by referencing some attributes of high_resolution_clock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkapiLib did not build on all systems due to not-officially-supported idioms and by referencing some attributes of high_resolution_clock.
Description of the Change
Makes OkapiLib buildable with Clang / on Mac OS
Motivation
Make contributing to the project more accessible.
Possible Drawbacks
The Workflow build is unaffected.
Switching from
std::chrono::high_resolution_clocktosystem_clockmay have different behavior on the V5 brain than on a typical computer.Verification Process
Library now builds without errors.
GitHub workflow
testis still successful at building the codeApplicable Issues
#4