Skip to content

[major] Updates to cached-miniforge #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[major] Updates to cached-miniforge #145

wants to merge 9 commits into from

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented May 1, 2025

As of five days ago, are getting CI issues. The mamba example on setup-miniconda stopped working too. I can't find or figure out a good direct attack, but mamba is deprecated anyhow so let's see whether it's possible to simply get around the problem by modernizing our setup-miniconda usage.

  • Using mamba is deprecated, don't bother
  • Localize env names containing paths with a ./ -- partially fixes CI failure debugging pyiron_workflow#634
  • Remove the backwards compatible env name input (since removing the mamba flags breaks the interface anyhow)
  • Sneaky unrelated: patch the sed invocation for osx

It's been just about a year since v3 dropped, so instead of deprecating the use_mamba flag, let's just get rid of it, clean up the other deprecated flag, and make a major bump to v4 here.

Whatever made the prepended ./ in the env names suddenly necessary broke other things too, so I'm hoping it gets rolled back/fixed. However, I don't see that including it here hurts anything, so let's keep it around either way.

liamhuber added 4 commits May 1, 2025 11:11
It is deprecated by setup-miniconda

Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
liamhuber added 2 commits May 2, 2025 06:24
This should fix the unittests side of pyiron/pyiron_workflow#634

Signed-off-by: liamhuber <[email protected]>
@liamhuber liamhuber changed the title Updates to cached-miniforge [major] Updates to cached-miniforge May 2, 2025
Just reference the input directly. Just a bug in the last commit, my bad.

Signed-off-by: liamhuber <[email protected]>
@liamhuber
Copy link
Member Author

Verified as working in pyiron/pyiron_workflow#636

@liamhuber
Copy link
Member Author

It turns out that fixing this also seems to have resolved what was going wrong with build-docs, as seen here: pyiron/pyiron_workflow#637

@liamhuber liamhuber marked this pull request as ready for review May 3, 2025 13:41
@liamhuber
Copy link
Member Author

internal references need to be re-targeted, but that is the last step pre-merge, because we need the branch-specific targeting to test behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure debugging
1 participant