-
Notifications
You must be signed in to change notification settings - Fork 0
[major] Updates to cached-miniforge #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liamhuber
wants to merge
9
commits into
main
Choose a base branch
from
use_miniconda
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated by setup-miniconda Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
This was referenced May 1, 2025
This should fix the unittests side of pyiron/pyiron_workflow#634 Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Just reference the input directly. Just a bug in the last commit, my bad. Signed-off-by: liamhuber <[email protected]>
Verified as working in pyiron/pyiron_workflow#636 |
It turns out that fixing this also seems to have resolved what was going wrong with |
internal references need to be re-targeted, but that is the last step pre-merge, because we need the branch-specific targeting to test behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of five days ago, are getting CI issues. The mamba example on setup-miniconda stopped working too. I can't find or figure out a good direct attack, but mamba is deprecated anyhow so let's see whether it's possible to simply get around the problem by modernizing our setup-miniconda usage.
./
-- partially fixes CI failure debugging pyiron_workflow#634sed
invocation for osxIt's been just about a year since v3 dropped, so instead of deprecating the
use_mamba
flag, let's just get rid of it, clean up the other deprecated flag, and make a major bump to v4 here.Whatever made the prepended
./
in the env names suddenly necessary broke other things too, so I'm hoping it gets rolled back/fixed. However, I don't see that including it here hurts anything, so let's keep it around either way.