-
Notifications
You must be signed in to change notification settings - Fork 2
Replace all the tests with something super simple #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
To try to track down what is going wrong upstream with the placements of conda env files Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
That's why we had no env I guess Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Ok, beautiful, this works fine:
Now let's turn on miniforge and see what happens |
That didn't break anything in the tests -- all 196 ran ok -- but the job is anyhow hanging for a long time afterwards. |
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
I had an upstream typo in deactivating the When I look at the respective invocations of setup-miniconda, the difference is in |
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Perfect! Yes, then it looks like the trouble is that I'm providing a path-like env name. This is interesting, because setup-miniconda explicitly claims to handle path-like values. Again though, since that code hasn't been touched in four months and the problem is only five days old, maybe it still lies somewhere else. I also find it further strange, because the failed mamba example also started 5 days ago, but there the |
Both de-pathing the environment name ( Interestingly, in the latter case, the conda info is still the big full path:
This is the exact path when we didn't localize and failed, so conda info is sanitizing the path sensibly, but I guess some other step in the process is not. That is so bizarre that I'm going to revert the |
Signed-off-by: liamhuber <[email protected]>
Ok, this informs me how to modify pyiron/actions#145 to get around this problem. However, I still have no idea about the docs job, and something still changed in a negative way somewhere upstream. So for the moment let's sit and wait. |
Signed-off-by: liamhuber <[email protected]>
Alright, using default parameters works so pyiron/actions#145 is fixing half of #634 (I still don't know what's going on with building the docs) |
To try to track down what is going wrong upstream with the placements of conda env files. Trying to make progress on #634 .