Drop wheel and setuptools from shared libs
#1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable running the remaining shared library `pip` using `pipx run`.
uranusjr
reviewed
Oct 18, 2023
CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| ## dev | |||
|
|
|||
| - Drop `setuptools` and `wheel` from the shared libraries | |||
There was a problem hiding this comment.
It may be a good idea to describe briefly what this means to end users.
There was a problem hiding this comment.
Sure, done. Have you already considered adopting towncrier for pipx? This would also simplify categorizing the changes.
webknjaz
reviewed
Nov 30, 2023
And enable running the remaining shared library `pip` using `pipx run`.
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
chrysle
force-pushed
the
shared-libs-drop-setuptools-wheel
branch
from
ddd41e3
to
913e823
Compare
|
Thank you! |
|
We need to fix the CI first 😎 |
It should be fixed in #1117. |
|
@chrysle Please fix linting. |
chrysle
force-pushed
the
shared-libs-drop-setuptools-wheel
branch
from
1688741
to
995a1a7
Compare
…e/pipx into shared-libs-drop-setuptools-wheel
chrysle
force-pushed
the
shared-libs-drop-setuptools-wheel
branch
from
995a1a7
to
df0efad
Compare
|
Done! |
|
Thanks! |
|
This change did not have the intended effect. Instead, it had the effect of leaving an old setuptools lingering in the shared libs, because that's what See #1539 for why that's worse than upgrading it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And enable running and installing the remaining shared library
pipusingpipx run. I have transferred the hack from #970 per #951 (comment) for use withpip.pipx run wheel/install wheeldoesn't work #951setuptoolsandwheelfrom shared libs #990docs/changelog.mdSummary of changes
Test plan
Tested by running