Fix: Updates api ip address & fix loop #15
Conversation
| @@ -10,7 +10,7 @@ export const useImages = () => { | |||
| for (let index = 0; index < 50; index++) { | |||
| try { | |||
| const data = await axios.get( | |||
| 'http://141.94.127.211:8000/get_unlabeled_random_event', | |||
| 'http://57.128.107.129:8000/get_unlabeled_random_event', | |||
There was a problem hiding this comment.
Maybe we can extract http://57.128.107.129:8000 in a top level const so we don't forget to update both strings when we change the ip of the server
| const koalaImage = | ||
| 'https://images.unsplash.com/photo-1459262838948-3e2de6c1ec80?q=80&w=1080&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D'; | ||
|
|
||
| images = [ | ||
| ...images.slice(0, 10), | ||
| { gif: koalaImage, img_list: [], id: 0 }, | ||
| ...images.slice(10), | ||
| ]; | ||
| return images; |
There was a problem hiding this comment.
Good fix! I don't think it's a good idea to add an easter egg that adds that much complexity, especially for a POC
| const data = await axios.get( | ||
| 'http://141.94.127.211:8000/get_unlabeled_random_event', |
There was a problem hiding this comment.
I can have a look later but here we are doing something that is not great : we are awaiting for request i to finish before triggering request i+1.
A better approach would be to run all requests in parallel with Promise.allSettled. Promise.allSettled is better in this case than Promise.all because it won't throw an error if one of the call fails.
There was a problem hiding this comment.
Overall the best approach would be to have a route that returns a list of events, so that we don't need to trigger n calls to get n events.
There was a problem hiding this comment.
I am kind of react/tsx noob to implement Promise.all/allSettled but you are right, we want to avoid error if one of the call fails !
Yes, i agree -> a route returning a list of events (with a param n and a default value !) -> I am taking care to have this route soon !
Hi there,
This PR introduces the following modifications :
Updates API ip url -> the old server was not working anymore
Modifies the loop to get as many images as wanted in the loop -> With the previous code, I always ended up with just one event (and the magnificent koala) to categorise. I have the feeling that there was a return problem in the loop ("return image"s arriving too early), but I'm not at all familiar with typescript !
Happy to discuss it :)