Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support truncation and remove superfluous content #105

Merged
merged 7 commits into from
Sep 3, 2023

Conversation

ljwolf
Copy link
Member

@ljwolf ljwolf commented May 25, 2023

This addresses a few of the recent issues filed (#100 #101 #83). The shaping issue was caused by premature truncation for the j() function when running j_test(). For j_test(), we need to keep all support values of the j() function until the end, and then truncate.

The other superfluous files, such as ripley.py and deprecated statistics, are removed, too.

@ljwolf ljwolf requested a review from weikang9009 May 25, 2023 02:34
@weikang9009
Copy link
Member

@ljwolf Thanks for fixing this! It seems that test_j() did not pass?

@ljwolf
Copy link
Member Author

ljwolf commented May 25, 2023

Yep, still working. Wait til the tests pass to merge 😄 I will ping when this is ready for review!

@martinfleis
Copy link
Member

martinfleis commented Jul 2, 2023

@ljwolf do you think this could make it to the next meta? We need to cut a release anyway due to #107 so it would be nice to clean these deprecations at the same time.

@martinfleis
Copy link
Member

We'll also need to sync this and #109 but I can update #109 easily once this is in.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #105 (f359648) into main (de0470a) will increase coverage by 7.04%.
Report is 2 commits behind head on main.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   52.56%   59.61%   +7.04%     
==========================================
  Files          12       10       -2     
  Lines        1851     1404     -447     
  Branches      317      246      -71     
==========================================
- Hits          973      837     -136     
+ Misses        821      517     -304     
+ Partials       57       50       -7     
Files Changed Coverage Δ
pointpats/distance_statistics.py 72.77% <68.18%> (-2.23%) ⬇️
pointpats/process.py 20.18% <100.00%> (-28.90%) ⬇️
pointpats/window.py 68.00% <100.00%> (-1.57%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjsrey sjsrey merged commit 416bca9 into pysal:main Sep 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants