-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support truncation and remove superfluous content #105
Conversation
@ljwolf Thanks for fixing this! It seems that |
Yep, still working. Wait til the tests pass to merge 😄 I will ping when this is ready for review! |
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 52.56% 59.61% +7.04%
==========================================
Files 12 10 -2
Lines 1851 1404 -447
Branches 317 246 -71
==========================================
- Hits 973 837 -136
+ Misses 821 517 -304
+ Partials 57 50 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This addresses a few of the recent issues filed (#100 #101 #83). The shaping issue was caused by premature truncation for the
j()
function when runningj_test()
. Forj_test()
, we need to keep all support values of thej()
function until the end, and then truncate.The other superfluous files, such as
ripley.py
and deprecated statistics, are removed, too.