Skip to content

[ET-VK] Modify quantized linear naive shader to linearly dispatch work to improve performance. #10116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gh/trivedivivek/76/base
Choose a base branch
from
Open

[ET-VK] Modify quantized linear naive shader to linearly dispatch work to improve performance. #10116

wants to merge 3 commits into from

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented Apr 11, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This diff changes naive quantized linear mat mul op to use push constant instead of uniform buffers and change dispatch pattern to linear to improve performance.

Differential Revision: D72862490

@trivedivivek
[ET-VK] Modify quantized linear naive shader to linearly dispatch wor…
9526ad7 
…k to improve performance.

This diff changes naive quantized linear mat mul op to use push constant instead of uniform buffers and change dispatch pattern to linear to improve performance.

Differential Revision: [D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/)

[ghstack-poisoned]
@trivedivivek trivedivivek requested a review from SS-JIA as a code owner April 11, 2025 19:51
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10116

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 07cf9b1 with merge base c352672 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@trivedivivek trivedivivek mentioned this pull request Apr 8, 2025
Open
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
This was referenced Apr 9, 2025
Open
Open
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72862490

@trivedivivek
Update on "[ET-VK] Modify quantized linear naive shader to linearly d…
1e47f4b 
…ispatch work to improve performance."

This diff changes naive quantized linear mat mul op to use push constant instead of uniform buffers and change dispatch pattern to linear to improve performance.

Differential Revision: [D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72862490

@trivedivivek
Update on "[ET-VK] Modify quantized linear naive shader to linearly d…
07cf9b1 
…ispatch work to improve performance."

This diff changes naive quantized linear mat mul op to use push constant instead of uniform buffers and change dispatch pattern to linear to improve performance.

Differential Revision: [D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72862490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivedivivek @facebook-github-bot @SS-JIA