[ET-VK] Minor improvement to permute op. #10117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) [ghstack-poisoned]
This was referenced Apr 8, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10117
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 35faf60 with merge base 047bbc7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
Apr 11, 2025
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) ghstack-source-id: 277629582 Pull Request resolved: #10117
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72866962 |
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 14, 2025
Pull Request resolved: #10117 This change reduces the complexity of boundary comparison in permute op to improve speed. ghstack-source-id: 277869187 @exported-using-ghexport Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
|
This pull request was exported from Phabricator. Differential Revision: D72866962 |
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 14, 2025
Pull Request resolved: #10117 This change reduces the complexity of boundary comparison in permute op to improve speed. ghstack-source-id: 277933492 @exported-using-ghexport Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
|
This pull request was exported from Phabricator. Differential Revision: D72866962 |
SS-JIA
approved these changes
Apr 14, 2025
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: #10117 This change reduces the complexity of boundary comparison in permute op to improve speed. ghstack-source-id: 278374767 @exported-using-ghexport Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
|
This pull request was exported from Phabricator. Differential Revision: D72866962 |
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: #10117 This change reduces the complexity of boundary comparison in permute op to improve speed. ghstack-source-id: 278469022 @exported-using-ghexport Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
|
This pull request was exported from Phabricator. Differential Revision: D72866962 |
This change reduces the complexity of boundary comparison in permute op to improve speed. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: #10117 This change reduces the complexity of boundary comparison in permute op to improve speed. ghstack-source-id: 278469606 @exported-using-ghexport Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
|
This pull request was exported from Phabricator. Differential Revision: D72866962 |
SS-JIA
pushed a commit
that referenced
this pull request
Apr 16, 2025
Contains commits squashed from #10117 PR stack. Differential Revision: D72866962 Differential Revision: D72862490 Differential Revision: D72581293 Differential Revision: D72430290
SS-JIA
added a commit
that referenced
this pull request
Apr 16, 2025
Contains commits squashed from #10117 PR stack. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) Differential Revision: [D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/) Differential Revision: [D72581293](https://our.internmc.facebook.com/intern/diff/D72581293/) Differential Revision: [D72430290](https://our.internmc.facebook.com/intern/diff/D72430290/) @diff-train-skip-merge Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Contains commits squashed from pytorch#10117 PR stack. Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/) Differential Revision: [D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/) Differential Revision: [D72581293](https://our.internmc.facebook.com/intern/diff/D72581293/) Differential Revision: [D72430290](https://our.internmc.facebook.com/intern/diff/D72430290/) @diff-train-skip-merge Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change reduces the complexity of boundary comparison in permute op to improve speed.
Differential Revision: D72866962