Skip to content

Add QCQMC code part 1 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 14, 2024
Merged

Add QCQMC code part 1 #342

merged 18 commits into from
Jun 14, 2024

Conversation

fdmalone
Copy link
Collaborator

@fdmalone fdmalone commented May 4, 2024

Adds the top level modules from the qcqmc code repo:

  1. data: a light module for creating the data/ folder structure which is assumed throughout the code.
  2. utilities: various utility functions (I already know this is going to be rejected :))
  3. afqmc_circuits. Cirq circuits implementing some circuit primitives for the AFQMC trial wavefunction.

Also adds the requirements.

Screenshot 2024-05-03 at 11 12 40 PM

@fdmalone
Copy link
Collaborator Author

I've deleted unused code and marked utilites migration in for_refactor. I moved the configuration options to config.py

@fdmalone
Copy link
Collaborator Author

@mpharrigan PTAL

@fdmalone fdmalone mentioned this pull request Jun 11, 2024
@fdmalone
Copy link
Collaborator Author

@wjhuggins

This was referenced Jun 11, 2024
@mpharrigan
Copy link
Collaborator

mpharrigan commented Jun 11, 2024

please add an __init__.py file to qcqmc

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm but please add an __init__.py.

@fdmalone
Copy link
Collaborator Author

@mpharrigan PTAL

@fdmalone
Copy link
Collaborator Author

@mpharrigan / @wjhuggins

@fdmalone fdmalone requested a review from mpharrigan June 14, 2024 18:02
@mpharrigan mpharrigan merged commit 54a61ca into quantumlib:master Jun 14, 2024
5 checks passed
@fdmalone fdmalone deleted the qcqmc-1 branch June 14, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants